Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

An in-range update of qs is breaking the build 🚨 #29

Open
greenkeeper bot opened this issue Nov 25, 2018 · 2 comments
Open

An in-range update of qs is breaking the build 🚨 #29

greenkeeper bot opened this issue Nov 25, 2018 · 2 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Nov 25, 2018

The dependency qs was updated from 6.5.2 to 6.6.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

qs is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 33 commits.

  • 34af57e v6.6.0
  • 8a8028e [Dev Deps] update browserify, eslint
  • 0a2d26f [New] move two-value combine to a utils function
  • b853cb8 [refactor] stringify: Avoid arr = arr.concat(...), push to the existing instance
  • 98126ef [Fix] stringify: fix a crash with strictNullHandling and a custom filter/serializeDate
  • 58d9b3e [Tests] temporarily allow node 0.6 to fail
  • ca259b3 [Tests] up to node v11.2, v10.13, v8.13
  • 97ad647 [Dev Deps] update eslint
  • 0da164d [Fix] utils: merge: fix crash when source is a truthy primitive & no options are provided
  • ac6d4ce [Fix] stringify: do not crash when the following criteria are met:
  • 2ea1424 [Tests] up to node v10.10, v8.12
  • 9c0428c [Refactor] utils: compactQueue: make it explicitly side-effecting.
  • 6f49e1a [Refactor] parse: one less concat call
  • 62ea1e1 [Refactor] add missing defaults
  • 380568b [Refactor] parse/stringify: clean up charset options checking; fix defaults

There are 33 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 25, 2018

After pinning to 6.5.2 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 22, 2019

  • The dependency qs was updated from 6.6.0 to 6.7.0.

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 18 commits.

  • 125e103 v6.7.0
  • 7060e79 [Tests] up to node v11.12, v10.15, v8.15, v6.17
  • 9ec4149 [Dev Deps] update eslint, @ljharb/eslint-config, covert, tape
  • d33a369 [Tests] temporarily allow coverage to fail
  • 3c5725e [Tests] fix Buffer tests to work in node < 4.5 and node < 5.10
  • d3a52ee [Refactor] utils: isBuffer: small tweak; add tests
  • 41c42b8 [Robustness] stringify: cache Object.prototype.hasOwnProperty
  • 04a9017 [Tests] always use String(x) over x.toString()
  • c9720fe [Fix] utils.merge: avoid a crash with a null target and an array source
  • 8297462 [Refactor]: stringify/utils: cache Array.isArray
  • 3cd5200 [Refactor] utils: reduce observable [[Get]]s
  • 8bcb6a5 [Fix]utils.merge`: avoid a crash with a null target and a truthy non-array source
  • b84acba [New] stringily/parse: add comma as an arrayFormat option
  • f22e507 [Refactor] use cached Array.isArray
  • dc78092 [Refactor] parse/stringify: make a function to normalize the options

There are 18 commits in total.

See the full diff

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

0 participants