From 1c7eaaa699d0b2642326792d85fe9886337962e5 Mon Sep 17 00:00:00 2001 From: Victor Lee Date: Thu, 29 Apr 2021 15:14:49 -0700 Subject: [PATCH] updated isNetInvestmentIncome in AdvancedDividend - changed from int to bool - fixes #111 --- .../CorporateActions/Response/AdvancedDividendResponse.cs | 2 +- IEXSharpTest/Cloud/CoreData/CorporateActionsTest.cs | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/IEXSharp/Model/CoreData/CorporateActions/Response/AdvancedDividendResponse.cs b/IEXSharp/Model/CoreData/CorporateActions/Response/AdvancedDividendResponse.cs index e14bd970..5aeb9660 100644 --- a/IEXSharp/Model/CoreData/CorporateActions/Response/AdvancedDividendResponse.cs +++ b/IEXSharp/Model/CoreData/CorporateActions/Response/AdvancedDividendResponse.cs @@ -17,7 +17,7 @@ public class DividendAdvancedResponse : CorporateActionResponse public string declaredCurrencyCD { get; set; } public decimal declaredGrossAmount { get; set; } public int? isCapitalGains { get; set; } - public int? isNetInvestmentIncome { get; set; } + public bool? isNetInvestmentIncome { get; set; } public int? isDAP { get; set; } public int? isApproximate { get; set; } public DateTime? fxDate { get; set; } diff --git a/IEXSharpTest/Cloud/CoreData/CorporateActionsTest.cs b/IEXSharpTest/Cloud/CoreData/CorporateActionsTest.cs index b1179499..0b0013b4 100644 --- a/IEXSharpTest/Cloud/CoreData/CorporateActionsTest.cs +++ b/IEXSharpTest/Cloud/CoreData/CorporateActionsTest.cs @@ -91,6 +91,7 @@ public async Task DividendsAdvancedAsyncTest(TimeSeriesRange range) [TestCase("AAPL", TimeSeriesRange.LastQuarter, false, null, "")] [TestCase("AAPL", TimeSeriesRange.OneMonth, false, null, "")] [TestCase("AAPL", null, false, null, "")] + [TestCase("PFF", null, false, null, "")] public async Task DividendsAdvancedAsyncTest(string symbol, TimeSeriesRange range, bool calendar, int last, string refId) { var response = await sandBoxClient.CorporateActions.DividendsAdvancedAsync(symbol, range, calendar, last, refId); @@ -108,8 +109,6 @@ public async Task DividendsAdvancedAsyncTest(string symbol, TimeSeriesRange rang Assert.Greater(data.grossAmount, 0); Assert.IsFalse(string.IsNullOrEmpty(data.currency)); - Assert.IsFalse(string.IsNullOrEmpty(data.marker)); - Assert.IsFalse(string.IsNullOrEmpty(data.flag)); Assert.IsFalse(string.IsNullOrEmpty(data.securityType)); }