Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix appcat-apiserver #10

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Fix appcat-apiserver #10

merged 4 commits into from
Jun 17, 2024

Conversation

wejdross
Copy link
Member

Summary

  • Updated and fixed code generation (it's broken on master even)
  • Fixed Makefile so it's possible to load image into kindev built using make docker-build-branchtag
  • Fixed root issue with listing PostgreSQl backups by updating Go to 1.22.3

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@wejdross wejdross requested review from a team, Kidswiss, TheBigLee and zugao and removed request for a team June 13, 2024 20:08
zugao
zugao reviewed Jun 14, 2024
View reviewed changes
Makefile Show resolved Hide resolved
zugao
zugao approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before closing this ticket please make sure that listing appcat, backups and other api sever custom resources work

@wejdross wejdross merged commit f8fc834 into master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Awaiting requested review from Kidswiss Kidswiss was automatically assigned from vshn/schedar

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wejdross @zugao