Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VarTypeHint doesn't check function arguments #19

Open
DalekCraft2 opened this issue Oct 20, 2022 · 1 comment
Open

VarTypeHint doesn't check function arguments #19

DalekCraft2 opened this issue Oct 20, 2022 · 1 comment

Comments

@DalekCraft2
Copy link

VSCode v1.72.2, Haxe Checkstyle v1.8.1

I have the VarTypeHint option set to enforce_all, and it does detect lack of type hints most of the time, but it doesn't seem to notice when the arguments of a function lack type hints.
If I had this:

public function test(anArg, anotherArg, fooBar):Void {}

it would not show any warnings for the missing types.

Is this a bug with this extension or with Haxe Checkstyle itself? I have more things to report and I don't want to send a bunch of bug reports in the wrong repository.

@AlexHaxe
Copy link
Member

VarTypeHint only checks for variables (var and final) not function parameters. as far as I'm aware there is no test to enforce type hints for function parameters.

and that would be a checkstyle issue since it concerns checks, their scope and their configuration.
it would be an extension issue, if one of the quick fix code actions worked incorrectly or you had a proposal for enhancing or adding a code action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants