You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# what to do with layers after (embedded in) the target protocol
if absLayNum < len(self.protocols):
for embedded in self.protocols[absLayNum+1 : ]:
dissectsub = ParsedMessage._getElementByName(layersvalue, embedded)
if isinstance(dissectsub, list):
self._dissectfull += dissectsub
# else:
# print("Bogus protocol layer ignored: {}".format(embedded))
Thing is, I actually want to test the dissections of a protocol that encapsulates layers and the way I see it, FMS should only test the dissection of the protocol itself and not of the whole message, this is why I deactivated this part in my slightly adapted implementation. But I know PRE tools would handle this differently. Do you have any idea, if there is a way to solve this issues elegantly? I am not sure, if this drastic commenting of mine is causing some problems later on.
The text was updated successfully, but these errors were encountered:
I am thinking about a parameter that can be submitted to the Comparator to decide in following layers are omitted. If I find a nice and clean solution, I will open a PR for that.
The code of nemere (more precisely the FMS part) raises a very interesting question:
The response is to just include them to the dissections:
Thing is, I actually want to test the dissections of a protocol that encapsulates layers and the way I see it, FMS should only test the dissection of the protocol itself and not of the whole message, this is why I deactivated this part in my slightly adapted implementation. But I know PRE tools would handle this differently. Do you have any idea, if there is a way to solve this issues elegantly? I am not sure, if this drastic commenting of mine is causing some problems later on.
The text was updated successfully, but these errors were encountered: