-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement API KEY #12
Comments
Have you started working on this yet? If not I would be keen to implement this. I'll raise a PR when done Cheers, |
Hey @foxjerem no I didn't. Feel free to send me a pull request. The API key is optional, so just make sure that the API works with/without api key. thanks! |
Is this still an active project? |
Am 06.08.2016 00:26 schrieb "ninp0" [email protected]:
Yes sure. But I cannot force people to contribute :) @ninp0 to disable the API key isn't an option? |
Hi @ninp0 , I don't see a reason why it should be a risk, running in an isolated environment and where an attacker shouldn't reach ZAP directly. Feel free to send me a pull request. If you decide to do, I think you should add an option to all methods to give the API KEY as parameter and it get used if the object has the api key enabled. To save the API KEY in the object, won't help you, otherwise an attacker could abuse ZAP using the ruby objects anyway.. |
starting on version 2.4.1 api comes automatically configured.
We should support it in all write/destructive actions. For now I'm disabling it and supporting it in the zap initialization. However It's not implemented in any method.. please check https://github.com/vpereira/owasp_zap/blob/master/lib/owasp_zap.rb#L88
The text was updated successfully, but these errors were encountered: