Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement API KEY #12

Open
vpereira opened this issue Sep 7, 2015 · 5 comments
Open

implement API KEY #12

vpereira opened this issue Sep 7, 2015 · 5 comments

Comments

@vpereira
Copy link
Owner

vpereira commented Sep 7, 2015

starting on version 2.4.1 api comes automatically configured.

We should support it in all write/destructive actions. For now I'm disabling it and supporting it in the zap initialization. However It's not implemented in any method.. please check https://github.com/vpereira/owasp_zap/blob/master/lib/owasp_zap.rb#L88

@0xff6a
Copy link

0xff6a commented Sep 18, 2015

Have you started working on this yet? If not I would be keen to implement this. I'll raise a PR when done

Cheers,
J

@vpereira
Copy link
Owner Author

Hey @foxjerem

no I didn't. Feel free to send me a pull request. The API key is optional, so just make sure that the API works with/without api key.

thanks!

@ninp0
Copy link

ninp0 commented Aug 5, 2016

Is this still an active project?

@vpereira
Copy link
Owner Author

vpereira commented Aug 6, 2016

Am 06.08.2016 00:26 schrieb "ninp0" [email protected]:

Is this still an active project?

Yes sure. But I cannot force people to contribute :)

@ninp0 to disable the API key isn't an option?

@vpereira
Copy link
Owner Author

vpereira commented Aug 8, 2016

Hi @ninp0 ,

I don't see a reason why it should be a risk, running in an isolated environment and where an attacker shouldn't reach ZAP directly.

Feel free to send me a pull request. If you decide to do, I think you should add an option to all methods to give the API KEY as parameter and it get used if the object has the api key enabled. To save the API KEY in the object, won't help you, otherwise an attacker could abuse ZAP using the ruby objects anyway..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants