Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #5 general comments #20

Open
rdgao opened this issue Nov 20, 2018 · 3 comments
Open

Tutorial #5 general comments #20

rdgao opened this issue Nov 20, 2018 · 3 comments

Comments

@rdgao
Copy link

rdgao commented Nov 20, 2018

No description provided.

@LeoVascelli
Copy link

LeoVascelli commented Nov 20, 2018

  • maybe add vertical line at werever amplitude = 1 for the hilbert plot? Woud make it easier to spot the actual phase angle associated with maximum aplitude
  • Hilbert transform instead of "Hilbert function"

@lakimenon
Copy link

Typos:

  • "smalller" in the second point under the Simulated PAC signal image
  • "thes" instead of "these" in the last line before part 2
  • Under Phase and Amplitude of ECoG signal graph, it says "it's possible a positive correlation between these two measures." - maybe should be "...correlation exists between..."
  • Under "Determine the strength of the correlation..." : "yield" is misspelled as "yeild" towards the end
  • "historgram" under "Visualize coupled phase"
  • "realtionship" towards end of second paragraph in summary

Other comments:

  • Under the polar graph, it says that amplitude is steadily increasing around 135-180. This could be misleading as there is a general increase between 90 and 225, but it actually appears to be decreasing strictly between 135-180.

@meyhaa
Copy link

meyhaa commented May 7, 2019

  • Introduction
    • Links to filtering and PSD tutorials are broken
  • (2) Visualizing phase and amplitude in the time domain using filters
    • External resource/tutorial link is broken
    • Code may need more comments?
      • What does nyquist frequency mean? Is that a term I should already be familiar with? Or will it be explained in the tutorial linked above?
    • What is the Hilbert function/transform? When the Butterworth function was introduced in tutorial 2, there was a more detailed explanation (with what it’s useful for, parameters, why we use it, etc…. )
  • (3) PAC in neural data
    • Tutorial link is broken

Potential Key Terms for Glossary (list for you to narrow down/edit):
Phase-amplitude coupling (phase-amplitude relationship)
Cross-Frequency Coupling
Sinusoidal Signal
Hilbert Function
Phase (theta phase)
Amplitude Envelope (gamme envelope)
Pearson correlation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants