From de6e3fd09bfd3549cd635cb00e03ed8ba2a8dc92 Mon Sep 17 00:00:00 2001 From: Evgeni Golov Date: Sat, 28 Oct 2023 20:15:54 +0200 Subject: [PATCH] move desc and baseurl into yum class, they are not used otherwise --- manifests/repo/nodesource.pp | 4 ---- manifests/repo/nodesource/yum.pp | 5 ++++- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/manifests/repo/nodesource.pp b/manifests/repo/nodesource.pp index da3b5f79..42e0a5ac 100644 --- a/manifests/repo/nodesource.pp +++ b/manifests/repo/nodesource.pp @@ -10,10 +10,6 @@ case $facts['os']['family'] { 'RedHat': { - # nodesource repo - $descr = "Node.js Packages - \$basearch" - $baseurl = "https://rpm.nodesource.com/pub_${url_suffix}/nodistro/nodejs/\$basearch" - contain 'nodejs::repo::nodesource::yum' } 'Debian': { diff --git a/manifests/repo/nodesource/yum.pp b/manifests/repo/nodesource/yum.pp index 31f21de4..faf66cf6 100644 --- a/manifests/repo/nodesource/yum.pp +++ b/manifests/repo/nodesource/yum.pp @@ -1,12 +1,15 @@ # PRIVATE CLASS: Do not use directly. class nodejs::repo::nodesource::yum { - $baseurl = $nodejs::repo::nodesource::baseurl $descr = $nodejs::repo::nodesource::descr $ensure = $nodejs::repo::nodesource::ensure $priority = $nodejs::repo::nodesource::priority $proxy = $nodejs::repo::nodesource::proxy $proxy_password = $nodejs::repo::nodesource::proxy_password $proxy_username = $nodejs::repo::nodesource::proxy_username + $url_suffix = $nodejs::repo::nodesource::url_suffix + + $descr = 'Node.js Packages - \$basearch' + $baseurl = "https://rpm.nodesource.com/pub_${url_suffix}/nodistro/nodejs/\$basearch" $yum_failovermethod = (versioncmp($facts['os']['release']['major'], '8') >= 0 and $priority == 'absent') ? { true => 'absent',