Skip to content

Commit

Permalink
update metadata.json, CHANGELOG
Browse files Browse the repository at this point in the history
  • Loading branch information
David Gubler committed Apr 4, 2017
1 parent 42ff18e commit 5de09ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## v1.13.3 [2017-04-04]

* Remove broken and unnecessary YAML workaround from gitlab.rb.erb

## v1.13.2 [2017-04-03]

* Fix handling of integers and string quoting in gitlab.rb
Expand Down
2 changes: 1 addition & 1 deletion metadata.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vshn-gitlab",
"version": "1.13.2",
"version": "1.13.3",
"author": "vshn",
"summary": "Installation and configuration of Gitlab Omnibus",
"license": "BSD-3-Clause",
Expand Down

3 comments on commit 5de09ad

@LongLiveCHIEF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so yeah, everyone keeps forgetting the attributes keys for ldap, and they definitely don't work with this commit. I would've commented to keep this break from going to master, but I don't see a merge request anywhere with this commit in it.

@davidgubler
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a quick example of what doesn't work? We have three setups with LDAP, so I don't quite understand currently what the problem is.

The previous version with the YAML workaround had broken string encoding, the result was that LDAP passwords that contained a backslash didn't work.

@LongLiveCHIEF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard... i had to reformat the "strings" in my yaml, and now it works fine. 👍

Please sign in to comment.