Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic ssh key generation and other features #22

Open
rendhalver opened this issue Mar 17, 2014 · 8 comments
Open

automatic ssh key generation and other features #22

rendhalver opened this issue Mar 17, 2014 · 8 comments

Comments

@rendhalver
Copy link

Hi everyone.

I have been mucking around with an idea of automatically generating the ssh key for the backup user and setting it up on each client node.
It would probably replace the amanda::ssh_authorized_key class.
I found a modules to generate ssh keys and import them from puppetdb so it would probably need a switch to turn on because not everyone will have PuppetDB installed and setup. Although that is more likely given you are using exported resources for the dle code.
I have the code almost ready for testing in my environment, I would just need to move it into a new branch in my fork and submit a pull request.
Are you guys interested in putting this kind of feature into your module?

On a side note I have some other code to generate virtual tapes for amanda but it currently uses the future parser so i would need to back port it before I submit it.

@nibalizer
Copy link
Member

I think that feature would be a fine addition to this module. I again would like it to be behind some conditional logic so users would have to opt in, but I think its a valuable addition. As for future parser pull requests... thats a conversation happening everywhere in Puppet right now. I'm all for cutting a '3x' branch and flipping master over to the future parser.

@blkperl @nightfly19 @reidmv what do you think?

@rendhalver
Copy link
Author

Yep thats cool.
I will add some extra vars to switch these on.

You will probably need to wack in a metadata.json file with a list of supported puppet versions.
At least I think thats how you do it. That seems to be how puppetlabs does it.
I need to do that with my modules too because I can see future parser becoming way to useful.

@rendhalver
Copy link
Author

Just so you know I have been using your module for ages and have had my own fork for for a while with some additions like adding disk list entries but I was too distracted and you lads beat me to it.

I also added some code to manage an exclude list for a few dump types but that might need some fine grained management on the amanda.conf file.
I had this idea of building it with concat from a couple of defines.
ini_setting probably won't work.
Does that interest you lads as well?

(yes I am full of ideas and have embraced the idea of Total Management so I like to automate and manage everything on a node)

@blkperl
Copy link
Member

blkperl commented Mar 17, 2014

Future parser isn't enabled by default yet. I would hesitate to merge PRs into master that use features from it.

Glad to see activity on this module again. Keep sending pull requests with ideas. :)

@rendhalver
Copy link
Author

Yeah I am a bit hesitant too.
I will keep probably keep the code till lamda gets merged into mainline.
That's going to be a fun day.

I have the ssh key management one ready but it's going to clash with master until my ssh host key import branch is merged.
I will hold off till that happens and then submit a pull request.

@jyaworski
Copy link
Member

Hello:

What's the status of this?

@rendhalver
Copy link
Author

I haven't done much on this for a while.
I will revisit my code and let you know if I can push up a fix.

@igalic
Copy link

igalic commented May 17, 2016

thanks, @rendhalver!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants