-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension permissions #5
Comments
Based on the code, the extension's broad permissions could theoretically allow access to sensitive information, but looking at the actual code implementation in content.js, the extension only:
function getVideo() {
const youtubeVideo = document.querySelector('.html5-main-video');
if (youtubeVideo) return youtubeVideo;
return document.querySelector('video');
}
document.addEventListener("visibilitychange", function() {
const video = getVideo();
if (!video) return;
// ... PiP logic
}); The warning message appears because of the broad permissions requested (
The extension's code is focused solely on:
While the permissions could theoretically allow for accessing sensitive information, the implemented code doesn't utilize these capabilities for anything beyond its core PiP functionality. The warning is a standard Safari security measure based on the broad permissions requested, rather than the actual behaviour of the extension. |
Hey @mrjk05 , Right now the app has network capabilities (needed for updating) - if I can launch it in the AppStore one day this permission can also go away so there would technically be no way for me to get any information. |
Wondering why you need all the permissions?
The text was updated successfully, but these errors were encountered: