Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Config Strategy Regarding File Permissions #24

Open
volomike opened this issue Nov 29, 2011 · 0 comments
Open

Improve Config Strategy Regarding File Permissions #24

volomike opened this issue Nov 29, 2011 · 0 comments
Assignees
Labels
Milestone

Comments

@volomike
Copy link
Owner

Currently in the app folder, we have a config.php. However, imagine someone who takes Faster to make a software product, and he wants an install script to create the config.php. Two problems occur:

  1. We're not doing a file_exists check, and that causes an error.
  2. Since we're putting config.php in app, that means the customer who buys a software product made with Faster must do like a chmod -R 0755 app or chmod -R 0777 app. That's a problem because it opens up security issues that people might forget to undo. A better solution would be to move config.php into an app/_config path, and then a customer merely has to make app/_config writable, rather than app.

Because the config file is part of the framework, the config folder should probably be _config for consistency reasons. Besides, in some text editors, this sorts this folder to the top, which people kind of prefer.

Therefore, I suggest a change where we move config.php to app/_config, and then we revise index.php so that it does a file_exists check and moves on without it if necessary.

@ghost ghost assigned volomike Nov 29, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant