Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove install.sh (or maintain it better) #624

Open
r00t- opened this issue Jan 30, 2024 · 5 comments
Open

remove install.sh (or maintain it better) #624

r00t- opened this issue Jan 30, 2024 · 5 comments

Comments

@r00t-
Copy link
Contributor

r00t- commented Jan 30, 2024

split from #621

this is caused by a trivlal syntax error in install.sh,
it seems that nobody ever tried to use the mqtt option before.

i would personally vote to remove install.sh,
it's some attempt to make source installation easier,
in a nonstandard ad-hoc way, and it's failing, as demonstrated here.
we have (deb) packaging now,
the issues that install.sh tries to solve (installation of dependencies) should have better and more standardized soltions.
i.e. we have a redundant one with the dockerfile (which might aswell invoke install.sh, but chooses not to..

@r00t-
Copy link
Contributor Author

r00t- commented Jan 30, 2024

further issues in a quick attempt to test install.sh:

  • it invoked ldconfig, failing because that's not on $PATH for non-root users,
  • then tries to invoke sudo, assuming it's running as a regular user
  • it assumes debian-like package names?

@J-A-U
Copy link
Collaborator

J-A-U commented Feb 4, 2024

we have (deb) packaging now,

Install.sh would have been purged from wiki already if the deb-package had been working for me.
https://lists.volkszaehler.org/pipermail/volkszaehler-users/2023-May/017042.html

we have a redundant one with the dockerfile

I'm not familiar with docker and nobody else seem to bother to document it in our wiki.

@r00t-
Copy link
Contributor Author

r00t- commented Feb 4, 2024

@J-A-U:

Install.sh would have been purged from wiki already if the deb-package had been working for me.
https://lists.volkszaehler.org/pipermail/volkszaehler-users/2023-May/017042.html

slightly off the topic,
but i guess that's the bug that was reported and fixed at #605
i'mafraid i stopped reading the -users list long ago, just too much noise.

@narc-Ontakac2
Copy link
Collaborator

@J-A-U Could you please confirm if it is actually fixed.

I have added the armel architecture as a fix that should work on RPi 1. However I do not have the hardware to check it.

@narc-Ontakac2
Copy link
Collaborator

If install.sh stays (and OMS is a strong argument to keep it) the vzlogger.service file should be aligned with the Debian version. Currently the service installed by install.sh runs as root. There are also other minor shortcomings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants