Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial .wxs uses encoding='windows-1252' #293

Open
juliusl opened this issue May 30, 2024 · 2 comments
Open

initial .wxs uses encoding='windows-1252' #293

juliusl opened this issue May 30, 2024 · 2 comments
Assignees
Labels

Comments

@juliusl
Copy link

juliusl commented May 30, 2024

I noticed that this encoding was used instead of UTF-8. The consequence of not using UTF-8 is that wix convert (wix3 -> wix4) will fail silently.

Workaround is to just change it to encoding='utf-8'. Interestingly enough wix convert ends up removing the xml tag all together.

@juliusl juliusl changed the title initial .wix uses encoding='windows-1252' initial .wxs uses encoding='windows-1252' May 30, 2024
@volks73
Copy link
Owner

volks73 commented May 30, 2024

Does changing to utf-8 fail with wix3?

@juliusl
Copy link
Author

juliusl commented Jun 3, 2024

@volks73 wix3/cargo-wix appears to work with utf-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants