Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Authors field being optional in Rust v1.53.0 or newer #146

Open
volks73 opened this issue Dec 27, 2021 · 0 comments
Open

Handle Authors field being optional in Rust v1.53.0 or newer #146

volks73 opened this issue Dec 27, 2021 · 0 comments
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented Dec 27, 2021

As of Rust v1.53.0, the authors field is optional and not automatically added to the project's manifest, Cargo.toml. The current minimum version supported by this project is v1.40.0 and the tests currently run with Rust v1.50.0. However, if the tests are run with a newer version of Rust, >v1.53.0, the integration tests will fail with a Manifest("authors") error.

The test fixtures assume the authors field exist because cargo originally always added the field and it was required. The field is now optional, but it is used for the manufacturer and other metadata of the installer. A backwards compatible fix needs to be added and the assumption changed. The authors field should be treated like the other optional fields, i.e. a warning if not defined.

References

  1. https://stackoverflow.com/questions/67891784/how-can-i-set-default-authors-for-new-cargo-projects
  2. https://github.com/rust-lang/rfcs/blob/master/text/3052-optional-authors-field.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant