-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admission webhook - hierarchical queues can not have hierarchy parts that are a substring [0:i] of other queue hierarchy. #3759
Comments
/assign |
I think that issue is here:
We're just checking if our annotation hierarchy is a substring of other hierarchy, but it's not always a good check, because hierarchy may be at the same length, but with name that contains substring. |
Simple solution: just add a "/" at the end of hierarchy before check. Example 1: hierarchyInTree: "root/somename/suffixdev" How it works now? How it will work? Example 2 (from code comment): hierarchyInTree: "root/sci/dev" How it works now? How it will work? |
Description
If I create two queues like these:
Admission webhook throws:
Steps to reproduce the issue
Describe the results you received and expected
As mentioned, the result is a queue revocation done by the admission webhook. My expectation is that I should be able to create queues like root/someproject and root/someprojectdev.
What version of Volcano are you using?
1.9.0
Any other relevant information
I can pick up this issue, because currently I'm working on admission webhook in our internal env.
The text was updated successfully, but these errors were encountered: