Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overused judge has changed the origin meaning #3695

Open
lowang-bh opened this issue Aug 27, 2024 · 3 comments
Open

overused judge has changed the origin meaning #3695

lowang-bh opened this issue Aug 27, 2024 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lowang-bh
Copy link
Member

lowang-bh commented Aug 27, 2024

Description

The overused check use A.LessEqual(B), while A.LessEqual(B) return false if there is a dimension in A large than that in B, return true iff every dimension in A is less or equal to the one in B.

Before #1637, overused := !attr.allocated.LessEqual(attr.deserved, api.Zero), which means overused=true if there is one dimension resource in allocated large than that in deserved, otherwise overused is false when all dimensions in allocated are less equal to that in deserved.

But now, overused := attr.deserved.LessEqual(attr.allocated, api.Zero), which means overused is false if there is one dimension in deserved large than allocated, that's to say, if there is one dimension resource in allocated is less or equal to that in deserved, queue is not overused, which is not the origin meaning: overused=true if there is one dimension resource in allocated large than that in deserved

Steps to reproduce the issue

Describe the results you received and expected

Keep the origin meaning that overused=true if there is one dimension resource in allocated large than that in deserved, which is coorespding with the queue's share value. If queue's share value is large than 1, then it is overused.

What version of Volcano are you using?

master

Any other relevant information

Currently, the overused combined with allocatable works well on the scene described in #3537

@lowang-bh lowang-bh added the kind/bug Categorizes issue or PR as related to a bug. label Aug 27, 2024
@hwdef
Copy link
Member

hwdef commented Aug 27, 2024

I agree with

overused is there is one dimension resource in allocated large than that in deserved

@Monokaix
Copy link
Member

Monokaix commented Sep 2, 2024

We should also consider the requested resources, which is tracked in #3537, we can solve them together.

@zhaizhch
Copy link

deserved has changed the origin mean too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants