You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The overused check use A.LessEqual(B), while A.LessEqual(B) return false if there is a dimension in A large than that in B, return true iff every dimension in A is less or equal to the one in B.
Before #1637, overused := !attr.allocated.LessEqual(attr.deserved, api.Zero), which means overused=true if there is one dimension resource in allocated large than that in deserved, otherwise overused is false when all dimensions in allocated are less equal to that in deserved.
But now, overused := attr.deserved.LessEqual(attr.allocated, api.Zero), which means overused is false if there is one dimension in deserved large than allocated, that's to say, if there is one dimension resource in allocated is less or equal to that in deserved, queue is not overused, which is not the origin meaning: overused=true if there is one dimension resource in allocated large than that in deserved
Steps to reproduce the issue
Describe the results you received and expected
Keep the origin meaning that overused=true if there is one dimension resource in allocated large than that in deserved, which is coorespding with the queue's share value. If queue's share value is large than 1, then it is overused.
What version of Volcano are you using?
master
Any other relevant information
Currently, the overused combined with allocatable works well on the scene described in #3537
The text was updated successfully, but these errors were encountered:
Description
The overused check use A.LessEqual(B), while A.LessEqual(B) return false if there is a dimension in A large than that in B, return true iff every dimension in A is less or equal to the one in B.
Before #1637,
overused := !attr.allocated.LessEqual(attr.deserved, api.Zero)
, which meansoverused=true if there is one dimension resource in allocated large than that in deserved
, otherwise overused is false when all dimensions in allocated are less equal to that in deserved.But now,
overused := attr.deserved.LessEqual(attr.allocated, api.Zero)
, which means overused is false if there is one dimension in deserved large than allocated, that's to say,if there is one dimension resource in allocated is less or equal to that in deserved, queue is not overused
, which is not the origin meaning: overused=true if there is one dimension resource in allocated large than that in deservedSteps to reproduce the issue
Describe the results you received and expected
Keep the origin meaning that
overused=true if there is one dimension resource in allocated large than that in deserved
, which is coorespding with the queue's share value. If queue's share value is large than 1, then it is overused.What version of Volcano are you using?
master
Any other relevant information
Currently, the
overused
combined withallocatable
works well on the scene described in #3537The text was updated successfully, but these errors were encountered: