Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

victims log print a lot of details #3687

Open
lowang-bh opened this issue Aug 22, 2024 · 7 comments
Open

victims log print a lot of details #3687

lowang-bh opened this issue Aug 22, 2024 · 7 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lowang-bh
Copy link
Member

What is the problem you're trying to solve

victim pods has print the detail yaml, which is not necessary.

image

Describe the solution you'd like

just need basic task info like preemtor
image

Additional context

No response

@lowang-bh lowang-bh added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 22, 2024
@lowang-bh
Copy link
Member Author

/good-first-issue

@volcano-sh-bot
Copy link
Contributor

@lowang-bh:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 22, 2024
@rissh
Copy link

rissh commented Aug 22, 2024

Hey,

I want to give it a try and work on this issue. Can you please assign me this issue?
Please don't hesitate to give me any suggestions or guidance as I work on this task. I'm open to feedback and would appreciate any insights you have.

Thank you!

@lowang-bh
Copy link
Member Author

/assign @rissh

@rissh
Copy link

rissh commented Aug 24, 2024

@lowang-bh ,
Thank you for assigning me this issue. Could you please point me to the files related to it? I'm still getting familiar with Volcano.

@lowang-bh
Copy link
Member Author

Could you please point me to the files related to it? I'm still getting familiar with Volcano.

klog.V(4).InfoS("Victims from Gang plugins", "victims", victims, "preemptor", preemptor)

@rissh
Copy link

rissh commented Aug 29, 2024

Thanks, man! I will up the PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants