Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add webhook for jobflow and jobtemplate #3659

Open
hwdef opened this issue Aug 7, 2024 · 4 comments
Open

add webhook for jobflow and jobtemplate #3659

hwdef opened this issue Aug 7, 2024 · 4 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@hwdef
Copy link
Member

hwdef commented Aug 7, 2024

What is the problem you're trying to solve

Currently there is no check when creating jobflow and jobtemplate, this may cause the controller or scheduler to panic.

Describe the solution you'd like

add some check in admission for jobflow and jobtemplate.

Additional context

No response

@hwdef hwdef added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 7, 2024
@hwdef
Copy link
Member Author

hwdef commented Aug 7, 2024

/assign

@Monokaix
Copy link
Member

Monokaix commented Aug 8, 2024

Hi, please descriebe what checks are missing and why volcano will panic.

@hwdef
Copy link
Member Author

hwdef commented Aug 29, 2024

For jobflow:

  • The jobtemplate in jobflow cannot be repeated
  • The jobtemplate in the job cannot form a ring, which means that the jobtemplate needs to be a DAG.

For jobtemplate:

  • It should be the same as vcjob's vaildate

@hwdef
Copy link
Member Author

hwdef commented Aug 29, 2024

Jobtemlpate should reuse job's validate. Do you have any good suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants