sqlboiler-psql: remove check for namespace on pg_type #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will cause problems if there are types with the same name in multiple schemas. At the moment, SQLBoiler is not cross-schema aware. It would be better to actually make SQLBoiler cross-schema aware than patching smaller parts like this which could then cause undefined behaviours for others. If you are working on an entirely new project, I would suggest considering Bob which is heavily inspired by SQLBoiler and is cross-schema aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check on namespace can cause column_type to be null when type is in different namespace than column
Fix #1262