Skip to content

Commit

Permalink
feat: adding changes field (COR-3604) (#555)
Browse files Browse the repository at this point in the history
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements COR-3604**

### Brief description. What is this change?

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->

Adding a new `changes` field to API step logs. This object describes the diff in diagram variables when an API step executes. This change is purely to get around type-checking issues breaking the build in the related `general-runtime` PR>
  • Loading branch information
zhihil committed Oct 23, 2024
1 parent 73b5b31 commit a211af5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion packages/base-types/src/runtimeLogs/logs/steps/api.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { APIBodyType, APIMethod } from '@base-types/node/api';
import type { PathReference } from '@base-types/runtimeLogs/utils';
import type { PathReference, ValueChange } from '@base-types/runtimeLogs/utils';

import type { BaseStepLog } from '../base';
import type { StepLogKind } from '../kinds';
Expand All @@ -24,6 +24,7 @@ interface ApiLogMessageResponse {
interface ApiLogMessage {
request: ApiLogMessageRequest;
response: ApiLogMessageResponse;
changes: Record<string, ValueChange<unknown, unknown>>;
}

type VerboseApiLogMessageRequest = {
Expand Down Expand Up @@ -54,6 +55,7 @@ interface VerboseApiLogMessageResponse {
interface VerboseApiLogMessage {
request: VerboseApiLogMessageRequest;
response: VerboseApiLogMessageResponse;
changes: Record<string, ValueChange<unknown, unknown>>;
}

export type ApiStepLog =
Expand Down

0 comments on commit a211af5

Please sign in to comment.