-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: subscription, plan & permissions #841
Draft
elboletaire
wants to merge
1
commit into
develop
Choose a base branch
from
f/subscription-permissions
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 19, 2024 12:35
ba4dd78
to
e22a9f8
Compare
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 19, 2024 14:33
e22a9f8
to
cff6086
Compare
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 19, 2024 14:57
cff6086
to
dc73a2d
Compare
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 19, 2024 15:04
dc73a2d
to
83f1757
Compare
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 19, 2024 16:42
83f1757
to
f96376c
Compare
elboletaire
changed the title
WIP: subscription plan permissions
WIP: subscription, plan & permissions
Nov 20, 2024
What's done so far: - Created the new "subscription" view - Recovered the menu link to this new page - Show a table with the current subscription. It's been done as a table since it looks like it, but I'm not sure if it's useful considering there aren't plans for multiple subscriptions - Removed the "open modal" temporary button from the main menu - Such modal can now be opened using the "view plans & pricing" button in the new page - A new Subscription Provider/Context has been created, with a `permissions` method in order to check for permissions of the current plan, but it has not been applied yet anywhere - The pricing modal has been minimally changed to allow setting a custom title, and moving its contents into an independent component
elboletaire
force-pushed
the
f/subscription-permissions
branch
from
November 22, 2024 17:15
f96376c
to
ddf4638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done so far:
/admin/subscription
)Settings -> Subscription
)display: grid
we're using in the dashboard.permissions
method in order to check for permissions of the current plan, but it has not been applied yet anywhere