Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Wallet vs Signer flows #120

Open
nigeon opened this issue Nov 29, 2023 · 2 comments
Open

Review Wallet vs Signer flows #120

nigeon opened this issue Nov 29, 2023 · 2 comments
Assignees
Labels
bug Something isn't working chakra-components Things related to the chakra-components package on hold

Comments

@nigeon
Copy link
Contributor

nigeon commented Nov 29, 2023

When logged in using OAuth (oauth walet), voting page asks for a signature and when clicked it lets you vote without any input (probably a modal should be shown).

Refreshing the page doesn't recognize you and lets you vote again, even though looks like the vote will be overwritten (if possible).

@elboletaire elboletaire self-assigned this Nov 29, 2023
@elboletaire elboletaire added bug Something isn't working chakra-components Things related to the chakra-components package labels Nov 29, 2023
@elboletaire
Copy link
Member

I rename the issue to also track other possible Wallet flows that need review, like adding a ConfirmModal for Actions when the logged in account is a Wallet instead of a Signer (since signers will have to manually confirm the sign of a transaction, while Wallets do it in the background, making it silent for the end-user).

@elboletaire elboletaire changed the title Anon voting using OAuth wallet Review Wallet vs Signer flows Dec 4, 2023
@elboletaire
Copy link
Member

Set on hold since there's nothing that can be done here, at least not that we can think of.

The conditions are properly set here, the issues arise when using rainbowkit v2 (using wagmi/viem), since you need to convert ethers wallets to signers using an adapter, but ui-components are totally unaware of the wallet library used... the only fixes we could think of were altering the wallet object, but such alteration would require it to be always done by the end developers...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chakra-components Things related to the chakra-components package on hold
Projects
None yet
Development

No branches or pull requests

2 participants