Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better AddBatch error returns #10

Open
arnaucube opened this issue Aug 31, 2021 · 0 comments
Open

Better AddBatch error returns #10

arnaucube opened this issue Aug 31, 2021 · 0 comments

Comments

@arnaucube
Copy link
Collaborator

Currently AddBatch returns an array of invalids indexes, and if when adding the given key-values there is any errors, the method will return err=nil, while returning an array of the index of the invalid keys.
Initially this was done to not break the process when an error was found (like for example there can be one incorrect key but the rest are fine, the AddBatch should complete the rest of keys, and indicate that there is one key which was invalid).
This is not ideal, and should be updated to return the errors for each invalid key, allowing to know which was the cause of that invalid entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant