-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Ruby Characters #147
Comments
Dear ditmarvisser, Thank you for bringing up the concept of Ruby Characters in Asian scripts and how it could benefit Vocascan. We appreciate your effort in developing the functionality for Vocab Cards. To contribute your code, we recommend following the standard procedure of creating a Pull Request (PR) via forking the repository. By forking the repository, you can make changes to your own copy of the code and then propose those changes to be merged into the original repository. Here's a step-by-step guide to submitting a Pull Request:
Once your Pull Request is submitted, the repository maintainers will review your changes and provide feedback or merge them into the main repository if they are deemed appropriate. We look forward to reviewing your code contribution and appreciate your interest in improving Vocascan. Best regards, |
The PR is available with a couple questions: #148 |
In asian scripts like Japanese or Chinese there is a concept of Ruby Characters, annotative characters which accompany complex characters. In Japanese these are known as Furigana, and in Chinese as Bopomofo.
Vocascan could benefit from displaying these characters in the right way. Modern browsers all support Ruby Characters, and if they don't there is a fallback available.
I have made the functionality already for the Vocab Cards.
I do not have permission to make a branch right now. If I can be given that permission then I will share my code.
The Ruby Characters need to be entered in the database in a standard format. Use
[]
to enclose the base characters, and{}
to encase the Ruby characters.This is then parsed to create the appropriate HTML tags.
The text was updated successfully, but these errors were encountered: