Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Styles to override the default autofill style of browsers #140

Merged
merged 3 commits into from
Oct 4, 2022

Conversation

Adnan-Sait
Copy link

@Adnan-Sait Adnan-Sait commented Oct 1, 2022

Status Type
✅ Ready Bug

Description

Added background and color styling to override default styling when browser autofill is used

Motivation and Context

When autofill is used to fill the register / login forms the browser styling is applied to input fields. The default browser styling looks especially bad in dark mode where Webkit browsers apply a white background to the inputs. (Screenshot attached in the issue)

In this PR, the autofill styling has been overridden to appear the same as the default styling of the inputs. This PR fixes #137 issue.

Screenshots / GIFs (if appropriate):

vocascan-autofill-fix
vocascan-autofill_light

Checklist

  • I have read the CONTRIBUTING document.
  • I have considered the accessibility of my changes (i.e. did I add proper content descriptions to images, or run my changes with talkback enabled?)
  • I have documented my code if needed

Resolves

Fixes #137

@Tracer1337
Copy link
Member

Please fix the linter errors npm run lint:fix

@Adnan-Sait
Copy link
Author

@Tracer1337, I have fixed the lint issues

Tracer1337
Tracer1337 previously approved these changes Oct 1, 2022
@noctera noctera added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 1, 2022
@Tracer1337 Tracer1337 changed the base branch from main to experimental October 1, 2022 20:06
@Tracer1337 Tracer1337 dismissed their stale review October 1, 2022 20:06

The base branch was changed.

@Tracer1337
Copy link
Member

@noctera @luwol03 Please merge this

@noctera noctera merged commit 018ea4d into vocascan:experimental Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Styling is overridden when the input is filled using autocomplete
3 participants