-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark duplicate Vocabs #128
Comments
So if the same word(string) is typed in both foreign word and translation then a warning should be shown right? |
Checking the foreign word should be enough, as translations might defer from vocab sheet to vocab sheet (for this I would like to hear the opinion of @luwol03 ) You should add a warning below the input field. We already heave errors built into it, so maybe you can just adabt/rewrite it to support warnings too. On top of that add a confirmation dialogue that pops up using the submit button. Currently there is one downside with this Issue, as the Routes are not yet implemented. The status of progress is referenced in this issue here. But I think this shouldn't be a problem, as it can be simulated with test Objects temporarily to check if it is working. Please think of changing it to the "Api call" when creating the PR |
@ShivaRapolu01 I have just written with @luwol03 and we will check foreign word and translation. So we have different warnings for different duplicate types (all information will come from the server). I will update the issue for the new route tomorrow, so you can see the expected parameters and responses (vocascan/vocascan-server#91) |
Give a warning if vocab is duplicate:
Option: Give a warning below foreign word text field
Option: When clicking submit, open a popup that shows a duplicate warning, so you have to submit two times.
Or maybe just add both Options...
In order to achieve this feature, the route in the backend has to be implemented first. Check vocascan/vocascan-server#91 for status
The text was updated successfully, but these errors were encountered: