Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date range check for multiple schedules #124

Open
johnjohndoe opened this issue Jun 11, 2023 · 0 comments
Open

Date range check for multiple schedules #124

johnjohndoe opened this issue Jun 11, 2023 · 0 comments

Comments

@johnjohndoe
Copy link
Collaborator

Context

Currently, the schedule.py script checks if the date range of the "other schedule" matches the date range of the "primary schedule".

if day["date"] != self.day(target_day)["date"]:
    log.error(f"  ERROR: the other schedule's days have to match primary schedule, in some extend {day['date']} != {self.day(target_day)['date']}!")
    return False

Question

  • The following example shows that the "other schedules (workshop, academic) can be within the range of the "primary schedule" although the former start later or end later or both.
  • Therefore my question: Does the above check have to be that strict or can it allow a "contains case"?
    I do not have enough insights to feel qualified to rate negative effects which might be caused if the check is changed.
  • It would be great if the error message could state the reasoning for the check.

Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant