vmware autotools m4 macros broken for c++ only flags from pkg-config

[bzed]

Looking at
https://github.com/vmware/open-vm-tools/blob/stable-10.0.x/open-vm-tools/m4/vmtools.m4#L157
which will also be called for C++ libraries - all cflags from pkg-config will be assigned to cppflags. So even flags which might be c++ compiler compatible only will go in there.
Imho pkg-config -cflags need to go into CFLAGS for C libraries and CXXFLAGS for c++ libraries. And then use the appropriate ones. Right now building fails as libsigx-2.0-dev ships with -std=gnu11 in cflags and your m4 macros assign that to CPPFLAGS which is used for c code, too...

[ravindravmw]

Bernd, you are right. We are aware of the issue in the macro.

BTW, I have not seen this change in cflags for libsigc++-2.0 v2.6.1. Any idea in what version of the library this change is going to show up?

Thanks for letting us know about this upcoming change in libsigx-2.0, we will fix it.

[oliverkurth]

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=800399 . I think it's a Debian specific change.