Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up controller-runtime to v0.18.x #8274

Open
ywk253100 opened this issue Oct 8, 2024 · 0 comments · May be fixed by #8275
Open

Bump up controller-runtime to v0.18.x #8274

ywk253100 opened this issue Oct 8, 2024 · 0 comments · May be fixed by #8275
Assignees
@ywk253100
Milestone
v1.16

Comments

@ywk253100
Copy link
Contributor

The lib controller-runtime introduced several break changes in kubernetes-sigs/controller-runtime#2783, need the corresponding changes on the Velero side.

This is also needed to support #7526 because #7526 requires client-go v0.30 and only controller-runtime v0.18+ can work with client-go v0.30 according to https://github.com/kubernetes-sigs/controller-runtime?tab=readme-ov-file#compatibility

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added this to the v1.16 milestone Oct 8, 2024
@ywk253100 ywk253100 self-assigned this Oct 8, 2024
ywk253100 added a commit to ywk253100/velero that referenced this issue Oct 8, 2024
@ywk253100
Bump up version of client-go and controller-runtime
8d0fde5 
Bump up version of client-go to v0.30.5
Bump up version of controller-runtime to v0.18.5

Fixes vmware-tanzu#8274

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
@ywk253100 ywk253100 linked a pull request Oct 8, 2024 that will close this issue
Draft
3 tasks
ywk253100 added a commit to ywk253100/velero that referenced this issue Oct 8, 2024
@ywk253100
Bump up version of client-go and controller-runtime
0a4e417 
Bump up version of client-go to v0.30.5
Bump up version of controller-runtime to v0.18.5

Fixes vmware-tanzu#8274

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywk253100 ywk253100

Labels
None yet
Projects
None yet
Milestone
v1.16
Development

Successfully merging a pull request may close this issue.

Bump up version of client-go and controller-runtime ywk253100/velero
1 participant
@ywk253100