From 8b6c89cd4e796b2f965cea999945824288132cc0 Mon Sep 17 00:00:00 2001 From: piny940 <83708535+piny940@users.noreply.github.com> Date: Sat, 18 May 2024 11:00:47 +0900 Subject: [PATCH 1/2] Fix backup log to show error string, not index Signed-off-by: piny940 <83708535+piny940@users.noreply.github.com> --- pkg/controller/backup_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/backup_controller.go b/pkg/controller/backup_controller.go index 61daf020b1..cf7ab5393d 100644 --- a/pkg/controller/backup_controller.go +++ b/pkg/controller/backup_controller.go @@ -692,7 +692,7 @@ func (b *backupReconciler) runBackup(backup *pkgbackup.Request) error { // Completed yet. inProgressOperations, _, opsCompleted, opsFailed, errs := getBackupItemOperationProgress(backup.Backup, pluginManager, *backup.GetItemOperationsList()) if len(errs) > 0 { - for err := range errs { + for _, err := range errs { backupLog.Error(err) } } From 059effce9783b7573dcbc57de2df70359a540467 Mon Sep 17 00:00:00 2001 From: piny940 <83708535+piny940@users.noreply.github.com> Date: Sat, 18 May 2024 11:08:18 +0900 Subject: [PATCH 2/2] Add change log 7805 Signed-off-by: piny940 <83708535+piny940@users.noreply.github.com> --- changelogs/unreleased/7805-piny940 | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelogs/unreleased/7805-piny940 diff --git a/changelogs/unreleased/7805-piny940 b/changelogs/unreleased/7805-piny940 new file mode 100644 index 0000000000..b8de4e86f9 --- /dev/null +++ b/changelogs/unreleased/7805-piny940 @@ -0,0 +1 @@ +Fix backup log to show error string, not index