Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Add linting/code analysis #188

Closed
jrgarcia opened this issue Sep 27, 2020 · 4 comments · Fixed by #191 · May be fixed by #190
Closed

Add linting/code analysis #188

jrgarcia opened this issue Sep 27, 2020 · 4 comments · Fixed by #191 · May be fixed by #190
Assignees
Labels
enhancement good first issue Hacktoberfest https://hacktoberfest.digitalocean.com/

Comments

@jrgarcia
Copy link
Contributor

jrgarcia commented Sep 27, 2020

Add linting/code analysis to the project. Ideally, this would be from an external dependency (like RuboCop) and have a Rake task to run it. It would also be nice to have a GitHub Action to run this on every push and pull request.

@jrgarcia jrgarcia added enhancement good first issue Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Sep 27, 2020
@Atul9
Copy link
Contributor

Atul9 commented Sep 28, 2020

Hi @jrgarcia I would like to take this up. I will open a PR once the hacktoberfest starts.

@Atul9
Copy link
Contributor

Atul9 commented Oct 1, 2020

Hi @jrgarcia although the issue was assigned to me but still there is PR ^ opened to close this issue. If I open a PR will it be considered?

@jrgarcia
Copy link
Contributor Author

jrgarcia commented Oct 1, 2020

@Atul9 Certainly. To be clear, what I was hoping for wasn't to have the issues (which I know are many) corrected in the PR. What I'd really like is to just have the setup for this done and then to slowly tackle the issues. That way there aren't too many changes being made at once. RuboCop has a concept of "todo" files where it passes over the issues as it's been noted as being known and listed as a todo item. I'd ultimately like to slowly do these one by one so that if there is an issue with a change it will be easier to bisect and find the problem rather than having one large commit full of changes that just needs to be rolled back.

@Atul9
Copy link
Contributor

Atul9 commented Oct 1, 2020

Hi @jrgarcia, I have opened up a PR at #191, please check

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement good first issue Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants