Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backslash escapes are ignored #136

Open
jgm opened this issue Oct 28, 2012 · 5 comments
Open

Backslash escapes are ignored #136

jgm opened this issue Oct 28, 2012 · 5 comments

Comments

@jgm
Copy link

jgm commented Oct 28, 2012

Sundown does not seem to recognize backslash escapes. This is a bug according to the official markdown syntax description. It also makes it difficult for authors to insert literal symbols when they need to.

http://johnmacfarlane.net/babelmark2/?normalize=1&text=%5C!%5Balt%5D(%2Furl)%0A

http://johnmacfarlane.net/babelmark2/?normalize=1&text=%5C%60not+code%60%0A%0A

http://johnmacfarlane.net/babelmark2/?normalize=1&text=*the+%5C*+character*%0A%0A

etc.

@jgm
Copy link
Author

jgm commented Oct 28, 2012

@jgm
Copy link
Author

jgm commented Oct 28, 2012

@mildsunrise
Copy link

👍

@vmg Please fix that!
To not recognize backslash escapes is a very
grave bug in a Markdown engine.

I can confirm that happens with the
latest Sundown source.

PD: Also, look at the icon and your username.
There's no space between them! This is a GitHub bug, though.

@mildsunrise
Copy link

@jgm About title attributes, I disagree about your example.
You don't escape parentheses within an HTML attribute.

This renders correctly:

[Link](http://google.es "me (not you)")
=>  <a href="http://google.es" title="me (not you)">Link</a>

But this doesn't:

[Link](http://google.es "here \"we\" go")
=>  <a href="http://google.es" title="here \&quot;we\&quot; go">Link</a>

Neither does this:

[Link](http://google.es "here \\"we\\" go")
=>  <a href="http://google.es" title="here \\&quot;we\\&quot; go">Link</a>

@mildsunrise
Copy link

This should now be fully fixed in Hoedown's master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants