-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omniscript compiler fails even with Puppeteer installed #549
Comments
Happy New Year @irfanlai You need to raise a case with Salesforce to get your NPM key for the Vlocity repo. Once you have this, add it into your job file as per the instructions on the readme :) |
@centricadean We have Github actions for our Vlocity deployment. Where should I be adding the NPM key? Not able to figure it out from the instructions. |
@irfanlai, you need to add it to your YAML job file, like so: projectPath: . |
@centricadean Thanks for the job file example. I added the npm repo key and when we tested with omniscript, it deployed but it failed when compiling the LWC component with the below error. Any idea what is missing?
|
I've not seen that error before @irfanlai, you might need to raise a Salesforce case for that. I've noticed that you're on 900.452 which is quite out of date. Support will want you to upgrade to the latest package. You could give that a go first, and then if it still doesn't work, raise the case. |
Thanks for your quick reply. I rolled back the change but now every time an OS is getting deployed we are getting this error. |
If 900.452 is out of date what should it be and does Salesforce update this or we have to do it? |
We raised the case with Salesforce and the response was to check the file which is in the logs. 'UnexpectedFileFound: Unexpected file found in package directory: /home/runner/work/salesforce-ses/salesforce-ses/force-app/main/default/ChannelObjectLinkingRules/Match_phone_number_to_record_1623529206154.ChannelObjectLinkingRule-meta.xml' |
Does anyone know if VBT checks for file issues in the repo? Every time we delete the file mentioned in error in the next run we get a new file with the error. Below is the latest log.
|
same here on latest VBT v1.17.2. 100% reproducible. The file which is reported as 'unexpected' is not Vlocity related. It is regular Salesforce metadata in sibling folder. It seems that for some reason VBT is trying to apply convert operation on files outside of its scope.
We were trying to use |
also affected by this error.
The issue seems to be happening only when deploying an OmniScript with changes on it.. |
If u share an sfdx project with the problem I can repro and try to fix the cli. Right now it is impossible. |
I raised a case to Vlocity support and they confirmed that this is indeed a scope conflict. the vlocity plugin referenced the default path set in Only change the path when pipeline run so it won't affect local development with default Add this snippet in your yaml file before running the packDeploy
just ensure you don't commit the changes.. |
try adding |
projectPath in the job file is the directory where the vlocity components are saved, you just don't change it to the |
I think I understood what is happening now. I can fix it if sf assigns someone to review and approve PRs... When the source convertion command runs, salesforce-alm verifies if all source files in the current workspace are valid, even when we are only interested in converting lwc. Because this package is older and it does not know about new metadata files that can be in the source format, an exception is thrown. Read these lines to understand the problem: workspace.isValidSourcePath: IsValidSourcePath: Metadata defs: Possible solutions:
|
I remember I allowed devs to use their host sfdx cli to let them use the new updates of the source convertion command. It was kind of a hack I did to avoid having to manage another dependency. |
nice, yeah the metadataTypeInfos are in the metadataRegistry.ts, was hard-coded all in there. The first option would be a nice quick fix, it totally separate the scope of the vlocity components. It will not throw the error even if Salesforce release a new metadata type which extension results to invalid when isValidSourcePath runs. |
Just checking this thread after a long time, finally there has been updates here so I am not the only one having this issue. @AllanOricil Do you have a fix for this? I need this so very urgently as whenever we have an OS deployment using GIT, we have to manually go and activate them and it takes a good amount of time for us. |
If salesforce hires my company's services I can give maintenance on this cli 😎🤓🥸 LET'S DO A DEAL! I bet people here need my awesome js skills, right? just saying... |
Getting the following error when deploying and activating Vlocity datapacks with VBT. I have puppeteer installed in the deployment YAML.
Vlocity ver: [email protected]
Puppeteer ver: [email protected]
"An error occurred while loading OmniScript compiler: Error: Failed to get package '@vlocity-cme/omniscript-lwc-compiler' Response error 401 Unauthorized - If you are using Puppeteer for LWC compilation this error can be ignored."
The text was updated successfully, but these errors were encountered: