-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETSI ITS DENM ReferenceDenms extension flag problem #290
Comments
Looks like function asn1constraint_pullup() calling _remove_extensions(arg, ct_expr, 1); removes extension part of constraint SIZE(1..8,...). Though simply removing the calling of _remove_extensions(arg, ct_expr, 1); can add APC_EXTENSIBLE flag to asn_PER_type_ReferenceDenms_constr_1, it also break several regression tests when perform I don't have enough knowledge to verdict whether these regression tests need to be revised ? Or asn1constraint_pullup() should only call _remove_extensions(arg, ct_expr, 1); under certain condition ? |
@velichkov do you have any idea why it would ever make sense to remove extensions if they were specified? @vlm any comment here? Thanks! |
@mouse07410 , according to X.680, I.4.2.3 & I.4.4, there must be some conditions that extension additions are to be discarded, but related code logic might need be revised.
|
@brchiu the above seems to imply that the same ASN.1 file could produce encoding with member constraints either honored or dropped, depending on what format is used? |
DENM v1.3.1 defines |
I am working with asn1c for half a year meanwhile. It's an excellent tool. Many thanks for it.
I may have found a generator bug now. The (ETSI ITS) DENM ASN.1 spec (attached) has a definition:
It carries the extension marker. ActionID is a sequence of two elements, a complex type. In this combination it appears to be the only one of this kind in the entire DENM ASN.1 spec (and the imported ITS Common spec, included as integrated part in the attachment here).
In the C code produced by the asn1c generator for PER constraints I get
I encoded with asn1c UPER and I tried to decode with http://asn1-playground.oss.com/ without success. ReferenceDenms (RoadworksContainer in AlacarteContainer) and everything hereafter is out of sync and asn1-playground reports an error.
I then manually added the extension flag:
And now it all works, asn1-playground is happy.
ITS DENM v1.2.2.asn.zip
The text was updated successfully, but these errors were encountered: