You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have Dockerfile names based on devices, except for CUDA. This seems to be because CUDA is considered a first-class citizen for vllm (and Torch), making it "the default" that everyone references. However, I believe it's better to maintain consistency in naming conventions for all device Dockerfiles, such as using Dockerfile.<device>. So i wanted to dicuss if it is good to do that for CUDA file to Dockerfile.cuda
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Currently, we have Dockerfile names based on devices, except for CUDA. This seems to be because CUDA is considered a first-class citizen for vllm (and Torch), making it "the default" that everyone references. However, I believe it's better to maintain consistency in naming conventions for all device Dockerfiles, such as using
Dockerfile.<device>
. So i wanted to dicuss if it is good to do that for CUDA file toDockerfile.cuda
Beta Was this translation helpful? Give feedback.
All reactions