Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing issue with some of the US Address. #12

Open
eranjan90 opened this issue Oct 9, 2020 · 1 comment
Open

Parsing issue with some of the US Address. #12

eranjan90 opened this issue Oct 9, 2020 · 1 comment

Comments

@eranjan90
Copy link

Hi Vlad! Thanks for this amazing work. However, I noticed that the parser has problems with some of the US addresses.

Examples
These following addresses don't parse at all.

  • 20555 Devonshire Street #116 Chatsworth CA 91311

  • 260-C North El Camino Real Encinitas CA 92024-2852

  • 623 H St NW Floor 3 Washington DC 20001

Could you please take a look?

@davewilliamstx
Copy link

Vlad - seconding the props here. This is epic regex. I also have been finding a few US addresses the package currently misses, wanted to add them if they are helpful.

  • 5717 S. IH-35, Ste. 101 Austin, TX 78744
  • 9500 South IH-35, Ste. E-400 Austin, TX 78748
  • 8522 North Lamar Austin, TX 78753

These plus a couple of @eranjan90 's above would be solved by:

  • Allowing "-" character in street_name
  • Allowing occupancy to match on a simple "#" vs having to have suite/apartment/room in front
  • Making street_type optional...don't know if this leads to way more false positives, I would imagine it might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants