Sticky shift key

[doonv]

The bug

Pressing the Shift key once causes it to remain pressed after releasing it. This usually doesn't affect anything but it does effect ScrollArea scrolling, which forces horizontal scrolling after Shift was pressed.

Example

use bevy::prelude::*;
use bevy_egui::{egui, EguiContexts, EguiPlugin};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .add_plugins(EguiPlugin)
        // Systems that create Egui widgets should be run during the `CoreSet::Update` set,
        // or after the `EguiSet::BeginFrame` system (which belongs to the `CoreSet::PreUpdate` set).
        .add_systems(Update, ui_example_system)
        .run();
}

fn ui_example_system(mut contexts: EguiContexts) {
    egui::Window::new("Hello").show(contexts.ctx_mut(), |ui| {
        let pressed = ui.input(|i| i.modifiers.shift);
        info!("pressed? {pressed}");
        ui.label("world");
    });
}

It will start out printing pressed? false. But after tapping Shift it will only print pressed? true

[doonv]

Wait no it looks like it's a bevy problem?

[doonv]

Yeah it's a bevy problem. Should be fixed by bevyengine/bevy#10702.

[doonv]

Update: It was not fixed. This problem is still occurring to me in bevy_egui 0.27.0, Bevy's ButtonInput<KeyCode>::pressed(KeyCode::ShiftLeft) returns correct values.

[SludgePhD]

I opened a PR with a fix in #298