Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for S3 Directory analysis for #3 #10

Closed
vjeeva opened this issue Oct 9, 2017 · 6 comments
Closed

Support for S3 Directory analysis for #3 #10

vjeeva opened this issue Oct 9, 2017 · 6 comments

Comments

@vjeeva
Copy link
Owner

vjeeva commented Oct 9, 2017

Completely left that out!!! We need this. Trying to avoid hooking up S3 as a mount... My assumption already is that we are mounting the directory to be analyzed... Oops.

However, when moving to Kubernetes #7 it will be needed to have some type of network mount to decentralize the system. I already had Amazon EFS in mind for that (gonna need to add support for any other network mounts too eg SMB, etc).

This needs some thought. The issue is that the code assumes the backup paths are in the docker container /mount folder, which is mounted when the ui container is run. Can't do that with S3, and there are som solutions but many people advise against using S3 as a file system.

@vjeeva
Copy link
Owner Author

vjeeva commented Oct 9, 2017

https://github.com/s3fs-fuse/s3fs-fuse. As long as it's read only I think should be fine. Just gotta ensure it IS or CAN BE SET read-only.

This way we can keep our dumps in S3 and keep EFS for Kubernetes decentralization only, reducing costs and unneeded replication.

@vjeeva
Copy link
Owner Author

vjeeva commented Oct 9, 2017

Need to think about multiple buckets and multiple folders. They need to be mounted at the docker run level.

@vjeeva
Copy link
Owner Author

vjeeva commented Oct 9, 2017

Creating mounts per s3 bucket. For local, just have a general mount point then the config will have to point from there to the backups per config. Rather than mount multiple things, have it in one directory. I could make it multiple like the s3 mounts but that would complicate the config file for local too.

@vjeeva
Copy link
Owner Author

vjeeva commented Oct 10, 2017

Screw mounts. The software s3fs was too intensive, made the container too big. Rather just get an s3 ls written instead. Got a system for that written, generalized for any new transports.

vjeeva added a commit that referenced this issue Oct 10, 2017
…ing for any new transports, using S3 ls rather than mounting s3 as a directory.
vjeeva pushed a commit that referenced this issue Oct 10, 2017
…ing for any new transports, using S3 ls rather than mounting s3 as a directory. (#14)
@vjeeva
Copy link
Owner Author

vjeeva commented Oct 10, 2017

Merged, but I didn't test with an s3 backup running yet. The directory listing works though!

Almost working, need to fix my own AWS access to test fully. Once done, will close this ticket.

vjeeva pushed a commit that referenced this issue Oct 10, 2017
* Fixing #10, s3 directory listing works, generalized backup path grabbing for any new transports, using S3 ls rather than mounting s3 as a directory.

* Updated gitignore for personal files (not part of this ticket really but meh)
@vjeeva
Copy link
Owner Author

vjeeva commented Oct 10, 2017

Gonna take way longer than I thought. Closing, I'll reopen if it's an issue.

@vjeeva vjeeva closed this as completed Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant