From eb4b6e12bad0c76fbdba0e5c7e82df040e24052b Mon Sep 17 00:00:00 2001 From: MurakamiShinyu Date: Fri, 28 Jun 2024 02:08:04 +0900 Subject: [PATCH] fix: Flexbox not working on page floats (Regression in v2.28.0) - fix #1354 --- packages/core/src/vivliostyle/vgen.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/core/src/vivliostyle/vgen.ts b/packages/core/src/vivliostyle/vgen.ts index 2f6da5939..dbd8e8de8 100644 --- a/packages/core/src/vivliostyle/vgen.ts +++ b/packages/core/src/vivliostyle/vgen.ts @@ -794,7 +794,11 @@ export class ViewFactory elementStyle, computedStyle, ); - if (floatReference && PageFloats.isPageFloat(floatReference)) { + if ( + floatReference && + PageFloats.isPageFloat(floatReference) && + computedStyle["display"] === Css.ident.block + ) { // Fix page float margin collapsing issue (Issue #1282) computedStyle["display"] = Css.ident.flow_root; }