-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ideas to enhance current extension #17
Comments
Hey Vitaly, I appreciate opening this discussion. I'll go over some of your notes,
|
I agree with all points, although using angular seems like overkill. You should be able to achieve a simple popup with jquery alone. Or knowing that we are only targeting chrome, vanilla JS may suffice. From my perspective, the only missing feature of this tool is the ability to whitelist sites/IPs it is switched on for. I think the primary use case for this extension is as a development aid and as a developer I would only want it switched on for one or two domains. Heading out into the internet with this switched for everything is a major security concern. @mhahmadi's recent pull requests looked like they would address this, but the popup didn't work for me, though (yet to investigate why). I would also suggest keeping it simple and not try to add too many features :) Do one thing well. /begin subjective comments :) |
Anything new on that end :-) ? |
So I had little bit time on this week end and merge some pull requests.
Seems I finally start realize how I want to improve extension.
First of all I want keep switching on/off states as simple as is now. So maybe better get rid from popup page suggested by @mhahmadi . Instead settings have to move to options page available through context menu on extension icon or in through extension list page in chrome.
features:
as for current code:
@mhahmadi, @thegecko open to ideas. lets proceed conversation here.
The text was updated successfully, but these errors were encountered: