Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slowTestThreshold applies to the suite instead of individual tests #6534

Closed
6 tasks done
JesusTheHun opened this issue Sep 19, 2024 · 1 comment · Fixed by #6715
Closed
6 tasks done

slowTestThreshold applies to the suite instead of individual tests #6534

JesusTheHun opened this issue Sep 19, 2024 · 1 comment · Fixed by #6715
Labels
documentation Improvements or additions to documentation

Comments

@JesusTheHun
Copy link

Describe the bug

From documentation :

threshold in milliseconds for a test to be considered slow

In practice, if a suite takes longer than slowtestthreshold, the suite is considered slow.
I expect a test to be considered slow, but not a suite based on the sum of its tests execution time.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-rqmwvp?file=test%2Fbasic.test.ts

The threshold has been set to 100.

System Info

Stackblitz, `vitest@latest`

Used Package Manager

pnpm

Validations

@sheremet-va sheremet-va added p2-to-be-discussed Enhancement under consideration (priority) and removed pending triage labels Sep 26, 2024
@sheremet-va sheremet-va moved this to P2 - 4 in Team Board Sep 26, 2024
@sheremet-va
Copy link
Member

The team agrees this works as intended, and the documentation is wrong. We should update the docs.

@sheremet-va sheremet-va added documentation Improvements or additions to documentation and removed p2-to-be-discussed Enhancement under consideration (priority) labels Oct 10, 2024
@sheremet-va sheremet-va moved this from P2 - 4 to Has plan in Team Board Oct 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
Status: Has plan
Development

Successfully merging a pull request may close this issue.

2 participants