Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: use go-version-file: for go version in CI #16842

Closed
timvaillancourt opened this issue Sep 24, 2024 · 0 comments · Fixed by #16841
Closed

Feature Request: use go-version-file: for go version in CI #16842

timvaillancourt opened this issue Sep 24, 2024 · 0 comments · Fixed by #16841
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature

Comments

@timvaillancourt
Copy link
Contributor

Feature Description

Use go-version-file: go.mod to find the go version in .github/workflows, when the go version is equal to what is in go.mod

TL;DR: go-version-file: go.mod uses go line from go.mod to get a go version. We already have CI scripts ensuring that version is consistent with go.mod, so there should be little risk to this change

This will make it a bit easier to maintain the repo, and for the fork I maintain, it will make it easier to merge patch releases onto our in-house release - the main conflicts are go-version: updates

Use Case(s)

Maintainers of the Vitess repo or forks

@timvaillancourt timvaillancourt added Type: Feature Needs Triage This issue needs to be correctly labelled and triaged labels Sep 24, 2024
@timvaillancourt timvaillancourt linked a pull request Sep 24, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant