Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add no_scatter flag to vttestserver #15683

Closed
aparajon opened this issue Apr 9, 2024 · 0 comments · Fixed by #15670
Closed

Feature Request: Add no_scatter flag to vttestserver #15683

aparajon opened this issue Apr 9, 2024 · 0 comments · Fixed by #15670

Comments

@aparajon
Copy link
Contributor

aparajon commented Apr 9, 2024

Feature Description

The no_scatter flag is used today in the vtgate (and also vtcombo) to cause the planner to fail when a scatter query occurs. This flag however does not yet exist in vttestserver, which is a useful construct that is often used for local database testing.

Use Case(s)

We have found in practice that scatter queries can be quite dangerous, as scatter queries at higher levels of traffic can overwhelm a database and break things. One forcing function to prevent scatter queries is to use the no_scatter flag. Doing so at the test level in vttestserver can help consumers catch and prevent scatter queries earlier on in the development lifecycle.

@aparajon aparajon added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature labels Apr 9, 2024
@rohit-nayak-ps rohit-nayak-ps added Component: Query Serving and removed Needs Triage This issue needs to be correctly labelled and triaged labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants