-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance regression: UNION in v19 #15466
Comments
so, checking out the changes, it looks like we're waiting around to get all the input types before we figure out how to coerce the values properly. but really, we only need to do this if we're not sure about the input types from the get-go. i'm thinking we can speed things up a bit:
for a fix, how about:
|
TL;DR: There is no performance regression. Steps Taken to Understand the Issue:
Conclusion: |
In a recent change to the UNION engine primitive, we added logic to make sure the output types of the union columns are correct.
Unfortunately, this made our UNION code much, much slower than before.
The end-to-end test
TestUnionAll
, if we run it many times, shows the degradation.On v18 those 10000 iterations ran in a bit over 6 seconds:
On v19 though with the same 10000 iterations:
The text was updated successfully, but these errors were encountered: