Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: insert on duplicate key update missing BindVars #14729

Closed
wlx5575 opened this issue Dec 8, 2023 · 1 comment · Fixed by #14728
Closed

Bug Report: insert on duplicate key update missing BindVars #14729

wlx5575 opened this issue Dec 8, 2023 · 1 comment · Fixed by #14728

Comments

@wlx5575
Copy link
Contributor

wlx5575 commented Dec 8, 2023

Overview of the Issue

In V18, the addition of trimming bound variables during insert needs to be included for each shard in this pull request: #14064. However, the scenario of 'insert on duplicate key' has been overlooked, and the bound variables added are not included for 'on duplicate key' variables.

Reproduction Steps

vschema
"t10": {
"column_vindexes": [
{
"column": "sharding_key",
"name": "hash"
}
}

create table t10
(
id bigint,
sharding_key bigint,
col1 varchar(50),
col2 int,
col3 int,
primary key (id)
) Engine = InnoDB;

Binary Version

19.0.0-SNAPSHOT

Operating System and Environment details

Operating system  MAC
Kernel version Darwin 21.1.0
Architecture x86_64

Log Fragments

No response

@wlx5575 wlx5575 added Needs Triage This issue needs to be correctly labelled and triaged Type: Bug labels Dec 8, 2023
@wlx5575
Copy link
Contributor Author

wlx5575 commented Dec 8, 2023

I will fix this issue #14728

@rohit-nayak-ps rohit-nayak-ps added Component: Query Serving and removed Needs Triage This issue needs to be correctly labelled and triaged labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants