Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch S3 backups to aws-sdk-go-v2 #14712

Closed
rbranson opened this issue Dec 6, 2023 · 2 comments
Closed

Switch S3 backups to aws-sdk-go-v2 #14712

rbranson opened this issue Dec 6, 2023 · 2 comments

Comments

@rbranson
Copy link
Contributor

rbranson commented Dec 6, 2023

Feature Description

This isn't as much a feature as an internal improvement. The aws-sdk-go-v2 is a newer iteration of the design of the AWS SDK for Go.

Use Case(s)

aws-sdk-go-v2 improves upon a number of deficiencies in aws-sdk-go. This has tangible improvements -- for instance, it properly retries a much wider range of request errors (for example: SlowDown from S3, connection resets from KMS). This will reduce the number of spurious backup failures within Vitess. The API change is relatively straightforward and PlanetScale has found that it is has been drop-in compatible from a performance and functionality perspective for its internal backup storage implementation.

@rbranson rbranson added Needs Triage This issue needs to be correctly labelled and triaged Type: Feature labels Dec 6, 2023
@rohit-nayak-ps rohit-nayak-ps added Component: Backup and Restore and removed Needs Triage This issue needs to be correctly labelled and triaged labels Dec 7, 2023
@frouioui frouioui self-assigned this Jul 25, 2024
@frouioui
Copy link
Member

Assigning this to me, I will be taking this up between now and before the v21.0.0 code freeze.

@frouioui
Copy link
Member

Fixed by #16664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants