diff --git a/go/vt/vtctl/workflow/utils.go b/go/vt/vtctl/workflow/utils.go index 6299d71369b..98b4e70a299 100644 --- a/go/vt/vtctl/workflow/utils.go +++ b/go/vt/vtctl/workflow/utils.go @@ -668,7 +668,7 @@ func areTabletsAvailableToStreamFrom(ctx context.Context, req *vtctldatapb.Workf } if req.GetEnableReverseReplication() { // Ensure the tablet has the minimum privileges required on the sidecar database - // table in order to create the reverse workflow as part of the traffic switch. + // table in order to manage the reverse workflow as part of the traffic switch. for _, tablet := range tablets { wg.Add(1) go func() { diff --git a/go/vt/vttablet/tabletmanager/rpc_vreplication.go b/go/vt/vttablet/tabletmanager/rpc_vreplication.go index 764f690617c..73d1dbf049a 100644 --- a/go/vt/vttablet/tabletmanager/rpc_vreplication.go +++ b/go/vt/vttablet/tabletmanager/rpc_vreplication.go @@ -72,8 +72,8 @@ where u.user = %a or (d.db = %a and u.insert_priv = 'y' and u.update_priv = 'y' and u.delete_priv = 'y') or (t.db = %a and t.table_name = 'vreplication' and find_in_set('insert', t.table_priv) - and find_in_set('update', t.table_priv) - and find_in_set('delete', t.table_priv) + and find_in_set('update', t.table_priv) + and find_in_set('delete', t.table_priv) ) ) ` @@ -549,7 +549,7 @@ func (tm *TabletManager) UpdateVReplicationWorkflows(ctx context.Context, req *t // ValidateVReplicationPermissions validates that the --db_filtered_user has // the minimum permissions required on the sidecardb vreplication table -// needed in order to manager vreplication metatdata. +// needed in order to manager vreplication metadata. func (tm *TabletManager) ValidateVReplicationPermissions(ctx context.Context, req *tabletmanagerdatapb.ValidateVReplicationPermissionsRequest) (*tabletmanagerdatapb.ValidateVReplicationPermissionsResponse, error) { query, err := sqlparser.ParseAndBind(sqlValidateVReplicationPermissions, sqltypes.StringBindVariable(tm.DBConfigs.Filtered.User), diff --git a/proto/tabletmanagerdata.proto b/proto/tabletmanagerdata.proto index 7d9cd15c1b4..e196c255c76 100644 --- a/proto/tabletmanagerdata.proto +++ b/proto/tabletmanagerdata.proto @@ -642,7 +642,8 @@ message ValidateVReplicationPermissionsRequest { message ValidateVReplicationPermissionsResponse { // The --db_filtered_user on the tablet. string user = 1; - // Does the user have the expected full set of global permissions. + // Does the user have the minimum privileges needed to manage + // vreplication metadata. bool ok = 2; }