From 4a4b32bf85702e5267bd897c11e0ff3399e5ccb8 Mon Sep 17 00:00:00 2001 From: FlorentP <35779988+frouioui@users.noreply.github.com> Date: Sat, 18 Jun 2022 01:22:18 +0200 Subject: [PATCH] Modified the Pull Request review checklist to check for explicit Pull Request titles (#10485) * added an item to the PR review checklist Signed-off-by: Florent Poinsard * Improved english text in review checklist Signed-off-by: Florent Poinsard --- .github/workflows/comment_pull_request.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/comment_pull_request.yml b/.github/workflows/comment_pull_request.yml index 16a9cb60af3..6a6ceab6d40 100644 --- a/.github/workflows/comment_pull_request.yml +++ b/.github/workflows/comment_pull_request.yml @@ -26,6 +26,7 @@ jobs: Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request. #### General + - [ ] Ensure that the Pull Request has a descriptive title. - [ ] If this is a change that users need to know about, please apply the `release notes (needs details)` label so that merging is blocked unless the summary release notes document is included. - [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. - [ ] If a workflow is added or modified, each items in `Jobs` should be named in order to mark it as `required`. If the workflow should be required, the GitHub Admin should be notified.