From 39ade617f29dda828c4e83c3d637d98a85282886 Mon Sep 17 00:00:00 2001 From: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Date: Wed, 8 May 2024 15:05:13 +0530 Subject: [PATCH] Delete the deprecated vreplication tablet type flag (#15857) Signed-off-by: Manan Gupta --- changelog/20.0/20.0.0/summary.md | 9 +++++++-- go/vt/vttablet/tabletmanager/vreplication/flags.go | 4 ---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/changelog/20.0/20.0.0/summary.md b/changelog/20.0/20.0.0/summary.md index 68f7968a640..28d9542a456 100644 --- a/changelog/20.0/20.0.0/summary.md +++ b/changelog/20.0/20.0.0/summary.md @@ -4,7 +4,8 @@ - **[Major Changes](#major-changes)** - **[Deletions](#deletions)** - - [`Pool Capacity Flags Deletion`](#pool-flags-deletion) + - [`--vreplication_tablet_type` flag](#vreplication-tablet-type-deletion) + - [Pool Capacity Flags](#pool-flags-deletion) - [MySQL binaries in the vitess/lite Docker images](#vitess-lite) - [vitess/base and vitess/k8s Docker images](#base-k8s-images) - [`gh-ost` binary and endtoend tests](#gh-ost-binary-tests-removal) @@ -41,7 +42,11 @@ ### Deletion -#### Pool Capacity Flags Deletion +#### `--vreplication_tablet_type` flag + +The previously deprecated flag `--vreplication_tablet_type` has been deleted. + +#### Pool Capacity Flags The previously deprecated flags `--queryserver-config-query-pool-waiter-cap`, `--queryserver-config-stream-pool-waiter-cap` and `--queryserver-config-txpool-waiter-cap` have been deleted. diff --git a/go/vt/vttablet/tabletmanager/vreplication/flags.go b/go/vt/vttablet/tabletmanager/vreplication/flags.go index 9f328f48a68..e45158ab99a 100644 --- a/go/vt/vttablet/tabletmanager/vreplication/flags.go +++ b/go/vt/vttablet/tabletmanager/vreplication/flags.go @@ -59,10 +59,6 @@ func registerVReplicationFlags(fs *pflag.FlagSet) { fs.BoolVar(&vreplicationStoreCompressedGTID, "vreplication_store_compressed_gtid", vreplicationStoreCompressedGTID, "Store compressed gtids in the pos column of the sidecar database's vreplication table") fs.IntVar(&vreplicationParallelInsertWorkers, "vreplication-parallel-insert-workers", vreplicationParallelInsertWorkers, "Number of parallel insertion workers to use during copy phase. Set <= 1 to disable parallelism, or > 1 to enable concurrent insertion during copy phase.") - - // Deprecated and ignored in v19. - fs.String("vreplication_tablet_type", tabletTypesStr, "Comma-separated list of tablet types used as a source.") - fs.MarkDeprecated("vreplication_tablet_type", "As of v19 this is ignored and will be removed in a future release.") } func init() {